Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable false positive warning on shellcheck #7542

Conversation

fabriziomello
Copy link
Contributor

@fabriziomello fabriziomello commented Dec 16, 2024

https://github.com/timescale/timescaledb/actions/runs/12358516263/job/34489217274?pr=7538#step:4:7

Disable-check: approval-count
Disable-check: force-changelog-file

@fabriziomello fabriziomello added ci force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug" labels Dec 16, 2024
@fabriziomello fabriziomello self-assigned this Dec 16, 2024
@github-actions github-actions bot requested a review from antekresic December 16, 2024 18:18
Copy link

@antekresic, @mkindahl: please review this pull request.

Powered by pull-review

@github-actions github-actions bot requested a review from mkindahl December 16, 2024 18:18
Copy link
Member

@akuzm akuzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this shellcheck bug: koalaman/shellcheck#2660

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.24%. Comparing base (59f50f2) to head (dd552d0).
Report is 658 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7542      +/-   ##
==========================================
+ Coverage   80.06%   82.24%   +2.17%     
==========================================
  Files         190      230      +40     
  Lines       37181    43304    +6123     
  Branches     9450    10886    +1436     
==========================================
+ Hits        29770    35614    +5844     
- Misses       2997     3377     +380     
+ Partials     4414     4313     -101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabriziomello fabriziomello merged commit 1e80128 into timescale:main Dec 16, 2024
52 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-2.17.x ci force-auto-backport Automatically backport this PR or fix of this issue, even if it's not marked as "bug"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants