Fix ABI check on PG 16 #6293
Merged
Fix ABI check on PG 16 #6293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6293 +/- ##
==========================================
- Coverage 65.44% 65.42% -0.02%
==========================================
Files 247 247
Lines 57663 57617 -46
Branches 12819 12800 -19
==========================================
- Hits 37736 37695 -41
+ Misses 18087 18075 -12
- Partials 1840 1847 +7 see 15 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
svenklemm
approved these changes
Nov 8, 2023
|
@jnidzwetzki, @gayyappan: please review this pull request.
|
jnidzwetzki
reviewed
Nov 8, 2023
jnidzwetzki
reviewed
Nov 8, 2023
This changes the way of pinning OpenSSL 1.1, so that it supports the case of PG16 where both the oldest and the newest alpine docker images have OpenSSL 3. Depending on the PG versions, both old and new images might have either 1.1 or 3, so we first try to install the versioned 1.1 package, and if it fails, it means the unversioned package is 1.1 and we install it instead.
jnidzwetzki
approved these changes
Nov 8, 2023
fabriziomello
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way of pinning OpenSSL 1.1, so that it supports the case of PG16 where both the oldest and the newest alpine docker images have OpenSSL 3. Depending on the PG versions, both old and new images might have either 1.1 or 3, so we just try to install both packages.
Disable-check: force-changelog-file