-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add devenv to simplify local dev and ci #213
base: main
Are you sure you want to change the base?
Conversation
c08d2f5
to
aa7e282
Compare
Signed-off-by: Sebastian Webber <[email protected]>
aa7e282
to
8c4c22b
Compare
Signed-off-by: Sebastian Webber <[email protected]>
Signed-off-by: Sebastian Webber <[email protected]>
2aa4fdf
to
0e6aa7c
Compare
Signed-off-by: Sebastian Webber <[email protected]>
0e6aa7c
to
32b2bc2
Compare
Signed-off-by: Sebastian Webber <[email protected]>
66cbd52
to
1ba15f4
Compare
Signed-off-by: Sebastian Webber <[email protected]>
1ba15f4
to
2c02b99
Compare
Signed-off-by: Sebastian Webber <[email protected]>
both outputs to build the app and the docker image Signed-off-by: Sebastian Webber <[email protected]>
425ce15
to
f834437
Compare
Signed-off-by: Sebastian Webber <[email protected]>
be9bc87
to
69a08db
Compare
Sounds great 🤩 |
69a08db
to
0e7d8dc
Compare
Signed-off-by: Sebastian Webber <[email protected]>
0e7d8dc
to
a546994
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked a few questions and the conflict in the main.go need to be resolved. Do you think we should do that while we are doing the release with all those fixes? It doesn't look that CI change is going to help with any of those. What do you think of making a release and changing the CI afterwards independently?
|
||
outputs = let | ||
name = "terraform-provider-timescale"; | ||
version = "1.11.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can version be parametrised based on the tag? Do we have to remember updating it here every time when a new tag is released?
@@ -0,0 +1,240 @@ | |||
schema = 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's a generated file. Does it need to be re-generated every time something in go.mod changes?
@@ -0,0 +1,17 @@ | |||
{ pkgs, app, name, version, ... }: | |||
pkgs.dockerTools.buildImage { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is docker used in this repo? We are not building any containers here. Is it required here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not, just leaving as example. we may remove if you think that is a problem.
Signed-off-by: Sebastian Webber <[email protected]>
8ab6b57
to
f6583cc
Compare
TL;DR; this PR uses a tool called https://devenv.sh that adds support to run the ci tasks locally.
Changes
What it does:
govet
golangci-lint
go tests
What is missing:
what is optional but cool:
x86_64
andaarch64
Usage
Important
The pre-commit hooks will prevent committing if they fail.
Start by installing devenv: https://devenv.sh/getting-started/
to build the packages:
to run tests and all pre-commit checks:
devenv test
to run a dev environment with all tools installed and configured:
TODO: