This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Mark couple of font method as main actor #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottasoutherland
suggested changes
Oct 16, 2024
There was a problem hiding this comment.
I suspect you'd have problems trying to integrate this into our codebase as is. I'm guessing most of it would work, but i'm sure we have cases that fetch this font without being part of the mainactor. This is part of the reason i intend to move this over into the main iOS codebase, so we can test it out internally as we work on it without having to mess around with the package definitions. (tentatively planning this for next week).
Muhieddine-El-Kaissi
force-pushed
the
m/concurrency/font
branch
from
5e572e3 to
b11d4fc
Compare
scottasoutherland
approved these changes
Oct 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the initial plan was only to mark Mainactor for traitCollectionOverrideForTesting but that triggered a chain reaction of MainActors that we need to add anyway at the end