This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Allow toasts to adjust for keyboard presentation #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwroth
force-pushed
the
toast_keyboard
branch
from
5a8ba57 to
b92a632
Compare
dwroth
force-pushed
the
toast_keyboard
branch
from
b92a632 to
6465a41
Compare
Abdul-Moiz
reviewed
Sep 5, 2024
Comment on lines
+66
to
+67
| /// Call this function inside of UIApplicationDelegate's application(_:didFinishLaunchingWithOptions:) | ||
| /// to have toasts reposition themselves above the software keyboard |
There was a problem hiding this comment.
I don't see this being added to UIApplicationDelegate
There was a problem hiding this comment.
thumbprint-ios is a framework; it doesn't have an app delegate. Making the call to registerForKeyboardNotifications() would have to be done inside of the app that is importing the framework.
There was a problem hiding this comment.
Ahh, I was under the impression this was iOS repo.
Abdul-Moiz
approved these changes
Sep 5, 2024
scottasoutherland
approved these changes
Sep 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows toasts to adjust themselves upward and downward in response to the software keyboard being presented or dismissed.
Demo.mov