Upgrade to elasticsearch 7.1 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make adjustments based on significant changes to the elastic4s library. Update the retry logic to retry based on any failure, instead of specific status codes, since the status codes are not available via the new API, at least not without significant change to the codebase. Tested by running the becquerel service locally with ES tunneled to Dev ES cluster. Ran dozer in Dev, with copy of prod BQ data, to keep the data in ES close to prod. Ran a few queries from production to compare results.
dtboctor
previously approved these changes
Dec 3, 2021
neelavarrao
previously approved these changes
Dec 3, 2021
kamalacharya
dismissed stale reviews from neelavarrao and dtboctor
via
3a2fb67
Make adjustments based on significant changes to the elastic4s library. Update the retry logic to retry based on any failure, instead of specific status codes, since the status codes are not available via the new API, at least not without significant change to the codebase. Tested by running the becquerel service locally with ES tunneled to Dev ES cluster. Ran dozer in Dev, with copy of prod BQ data, to keep the data in ES close to prod. Ran a few queries from production to compare results.
kamalacharya
force-pushed
the
upgrade_to_es7
branch
from
3a2fb67 to
d089d6b
Compare
Jumped version from 1.0.3 to 1.1.0 since we upgraded to a higher version of Elasticsearch.
neelavarrao
previously approved these changes
Dec 10, 2021
neelavarrao
previously approved these changes
Dec 13, 2021
This library was migrated to the new home in maven central.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make adjustments based on significant changes to the elastic4s library.
Update the retry logic to retry based on any failure, instead of
specific status codes, since the status codes are not available via
the new API, at least not without significant change to the codebase.
Tested by running the becquerel service locally with ES tunneled to
Dev ES cluster. Ran dozer in Dev, with copy of prod BQ data, to keep
the data in ES close to prod. Ran a few queries from production to
compare results.