Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method redefinition and circular require issues #1027

Merged

Conversation

kholdrex
Copy link
Contributor

@kholdrex kholdrex commented Jun 20, 2024

#999

This PR addresses two issues:

  1. Method Redefinition: The user_parameter method was being defined multiple times in lib/clearance/configuration.rb. This has been fixed by changing attr_accessor to attr_writer, ensuring the method is defined only once.

  2. Circular Require: Circular dependencies between lib/clearance.rb and lib/clearance/engine.rb have been resolved by rearranging the require statements to avoid circular loading.

@kholdrex kholdrex requested a review from sej3506 as a code owner June 20, 2024 01:47
Copy link
Contributor

@sej3506 sej3506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good catch with the user_parameter method(s)!

@sej3506 sej3506 merged commit 1df5cf8 into thoughtbot:main Jun 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants