Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused axe-capybara dependency #17

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

seanpdoyle
Copy link
Contributor

The contents of the axe-capybara.rb file aren't necessary for capybara_accessibility_audit's pattern of usage.

This also sheds an indirect and unstated selenium-webdrivers dependency.

@seanpdoyle seanpdoyle force-pushed the remove-axe-capybara-require branch 2 times, most recently from f4732f5 to 56f28e3 Compare February 29, 2024 12:39
@seanpdoyle seanpdoyle changed the base branch from main to drop-2-7-eol February 29, 2024 12:39
@seanpdoyle seanpdoyle changed the title Remove unused require "axe-capybara" statement Remove unused axe-capybara dependency Feb 29, 2024
@seanpdoyle seanpdoyle force-pushed the remove-axe-capybara-require branch from 56f28e3 to 9ede921 Compare February 29, 2024 12:41
@seanpdoyle seanpdoyle force-pushed the remove-axe-capybara-require branch from 9ede921 to 425f2ac Compare February 29, 2024 12:42
@seanpdoyle seanpdoyle force-pushed the remove-axe-capybara-require branch from 425f2ac to eafcf38 Compare February 29, 2024 12:42
Base automatically changed from drop-2-7-eol to main February 29, 2024 12:45
The contents of the [axe-capybara.rb][] file aren't necessary for
`capybara_accessibility_audit`'s pattern of usage.

This also sheds an indirect and unstated `selenium-webdrivers`
dependency.

[axe-capybara.rb]: https://github.com/dequelabs/axe-core-gems/blob/develop/packages/axe-core-capybara/lib/axe-capybara.rb
@seanpdoyle seanpdoyle force-pushed the remove-axe-capybara-require branch from eafcf38 to 500ac61 Compare February 29, 2024 12:46
@seanpdoyle seanpdoyle merged commit f953d5e into main Feb 29, 2024
11 checks passed
@seanpdoyle seanpdoyle deleted the remove-axe-capybara-require branch February 29, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant