refactor: extract selector constants

this-is-learning · Aug 19, 2021 · 8786df9 · 8786df9
1 parent 0a54d25
commit 8786df9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/apps/this-is-learning/src/app/hello/hello.component.ts b/apps/this-is-learning/src/app/hello/hello.component.ts
@@ -4,13 +4,15 @@ import {
   ViewEncapsulation,
 } from '@angular/core';
 
+const selector = 'til-hello';
+
 @Component({
   changeDetection: ChangeDetectionStrategy.OnPush,
   encapsulation: ViewEncapsulation.None,
-  selector: 'til-hello',
+  selector,
   styles: [
     `
-      til-hello {
+      ${selector} {
         display: block;
       }
     `,

diff --git a/libs/publications/feature-this-is-angular/src/lib/shell/shell.component.ts b/libs/publications/feature-this-is-angular/src/lib/shell/shell.component.ts
@@ -5,13 +5,14 @@ import {
 } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 
+const selector = 'til-this-is-angular-shell';
 @Component({
   changeDetection: ChangeDetectionStrategy.OnPush,
   encapsulation: ViewEncapsulation.None,
-  selector: 'til-this-is-angular-shell',
+  selector,
   styles: [
     `
-      til-this-is-angular-shell {
+      ${selector} {
         display: block;
       }
     `,