Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate mysql to 8.4 in Docker compose #10548

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FinnIckler
Copy link
Member

Currently Upgrading staging but it seems to be working (staging replica already updated). Locally we need to add --mysql-native-password=ON as it's now deprecated and will be removed in version 9.

We can migrate to the new caching_sha2_password but that means every developer will need to recreate their database.

@FinnIckler
Copy link
Member Author

Another thing is that https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md currently uses mysql 8.0.40 so we could consider switching to another gh action that allows us to control mysql versions like https://github.com/marketplace/actions/actions-setup-mysql

@gregorbg
Copy link
Member

gregorbg commented Jan 6, 2025

I am very cautious about using core software setup steps that are not maintained by the official vendors.

For Ruby, there's a GH Action made by the Ruby folks. Same for NPM/Yarn. By any chance, is there an official MySQL or MariaDB action?

@FinnIckler FinnIckler marked this pull request as ready for review January 8, 2025 12:56
@FinnIckler
Copy link
Member Author

Now that prod is on 8.4 we should make sure to align this soon so we don't accidentally introduce any inconsistencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants