Let dropdowns expand beyond Modal body in EditEvents #10544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorbg
force-pushed
the
fixup/modal-scrolling
branch
from
f3a707c to
ddc9fe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really quick fix for #10522, although I'm not sure whether this breaks anything else. I did a few basic sanity checks, but I'm sure experienced Delegates have other use-cases for this panel...
Git Blame shows that we introduced the
scrollingproperty only in #8765, which was targeted towards a specific issue with scrolling in a long list of cumulative rounds. I have changed the code so that each nested modal can decide by itself whether it wants to be scrolling or not, although the new default value isfalse(as opposed to before. when every modal wasscrollingby default, which caused the issue with dropdowns)