Can only update a competition's currency code if there are no unrefunded payments #10497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1356 - in draft because I've asked WCAT if this is something that's still needed.
If this is needed, then I think this implementation may be a bit thin. If we get the mega-edge-case of a user having been over-refunded, and another user still having a not-yet-refunded payment, the total amount paid for a competition will be $0 even though there are still two unresolved payments.
As such, it might be better to
finda registration with a non-zero sum of itsregistration_paymentsAlso - it seems like we don't track the overall status of a payment (eg, whether it has been refunded) - we only infer this by summing registration_payments related to a given registration.