Support emitting ES6 modules #723
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because Closure Stylesheets is discontinued, it is unlikely that we will ever implement these in spec file. Maybe accept key-value pairs of css renaming maps manually?
This commit adds a new feature that allows users to perform build that generates es6 modules as output chunks. Previously, output chunks need to be executed in a shared global scope in order for later chunks to reference variables in previous chunks. By adding `chunkFormat` key to the spec file, the closure compiler build will be done using chunk_output_type = ES_MODULES, and rollup build will be done using a usual code-splitting build with tight control of each chunk's location in the final bundle. Currently it does not work with the spec file's `external` option. It "sort of" works for rollup, but again it still doesn't work with external modules specified with relative paths. On the closure compiler side, it is even less clear what should be done, but it seems clear that this is the way to go.
to make tests pass in Windows.
theseanl
force-pushed
the
rollup-manual-chunks
branch
from
8f9b160 to
ee7a75a
Compare
...and improve documentation for rollup-plugin-tscc.
|
Merged at 1088d6e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
packages/rollup-plugin-tscc/README.mdspec.chunkFormatinREADME.md"chunkFormat": "module"is used in conjunction with"external", until External module support for ES6 module output #724 is implemented.