Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sm simple list view style 26 #55

Merged
merged 12 commits into from
Oct 6, 2024
Merged

Sm simple list view style 26 #55

merged 12 commits into from
Oct 6, 2024

Conversation

sar-mko
Copy link
Collaborator

@sar-mko sar-mko commented Oct 4, 2024

Description

The main changes made were to the List page with more styles, and incorporates updates to our navbar to help make timely changes.

  • Updated the navbar in Layout.jsx and List Page on List.jsx and ListItem.jsx
  • Added the User's list name as the header
  • Added new global stylings in index.css
  • Added proper heading elements
  • Incorporated new colors and added responsiveness for the navbar for better user experience
  • New icons throughout the List Page
  • Removed ManageList from the navbar
  • Included more spacing between elements
  • Added aria-labels on elements with icons to provide better descriptions for screen-readers

Related Issue

closes #46 (Issue #26)

Acceptance Criteria

  • The list the user is working on is visible: [List Name] List is seen at the top of the list between new navbar and above Add Item button
  • Apply proper heading elements (ex. List Name is an h2)
  • “Hello from the /list page!” message is removed

Type of Changes

enhancement

Updates

Before

Screenshot 2024-10-04 at 12 19 51 PM

After

Screenshot 2024-10-04 at 12 02 18 PM

Testing Steps / QA Criteria

  • Pull from sm-simple-list-view-style-26 branch
  • Open the List page from the Navbar
  • See items and new stylings on List Page
  • Dropdown Icon( aka for seeing purchase details) toggles between open and close
  • Navbar is responsive on small screens
  • Navbar hamburger toggles between open and close on small screens

Copy link

github-actions bot commented Oct 4, 2024

Visit the preview URL for this PR (updated for commit 6369357):

https://tcl-76-smart-shopping-list--pr55-sm-simple-list-view-sod4glo0.web.app

(expires Fri, 11 Oct 2024 19:25:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 512b1a88be8ae05fd3e727b99332819df760271d

Copy link
Collaborator

@arandel1 arandel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! Especially love the navbar change when the screen is smaller. Nice job Sarah!

Copy link
Collaborator

@EmmaBin EmmaBin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love how it looks! Great job:)

Copy link
Collaborator

@MarcosPerez16 MarcosPerez16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@sar-mko sar-mko merged commit f5efbb0 into main Oct 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

26. As a user, I want a clean and simple view of my List
4 participants