Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KD] Stylize Header and Navbar #82

Merged
merged 15 commits into from
Apr 6, 2024
Merged

[KD] Stylize Header and Navbar #82

merged 15 commits into from
Apr 6, 2024

Conversation

piecanoe
Copy link
Collaborator

@piecanoe piecanoe commented Apr 3, 2024

Description

This code stylizes the header, navbar, and sign-in/sign-out button using the Aisle Be There brand colors and font.

Related Issue

Closes #80
Sub-Issue #14

Acceptance Criteria

  • Stylize the navbar with the brand colors

Type of Changes

Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g., bug fix or enhancement are common ones.

Updates

Before

before_1

After

Signed out
after_1

Signed in
after_2

Testing Steps / QA Criteria

  1. From 'Home' page, make you're signed out.
  2. Click the "here" to learn more link to navigate to the 'About' page.
  3. You should see a "Sign In" button at the top right. Hover over the button to see that it changes to a darker purple.
  4. Click "Sign In" to sign in.
  5. Once you're signed in, the "Sign In" button should change to a "Sign Out" button with your user profile image. Hover over the button to see that it changes to a darker purple.
  6. While still signed in, click on between the "lists" and "about" nav links to see that the active page is underlined while the other nav links are not.
  7. Click on "Aisle Be There" in the header to verify it navigates you to the home page.

@piecanoe piecanoe changed the title Kd stylize navbar [KD] Stylize Header and Navbar Apr 3, 2024
@piecanoe piecanoe self-assigned this Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Visit the preview URL for this PR (updated for commit 1061235):

https://tcl-69-smart-shopping-list--pr82-kd-stylize-navbar-6225o3cz.web.app

(expires Sat, 13 Apr 2024 00:56:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93172cc46147b7d365c2b1b8239b61e2efb07a80

@piecanoe piecanoe added enhancement New feature or request design sprint design sprint from issue 14 labels Apr 4, 2024
@piecanoe piecanoe marked this pull request as ready for review April 5, 2024 20:55
Copy link
Collaborator

@krsnamara krsnamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very exciting to see the app starting to take shape design wise.


.Layout-header button {
background: transparent;
color: var(--color-text);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the deployed it appears that this overrides the button styles in index making the text in the signin/signout button black. Suggestion is to remove this line

Copy link
Collaborator Author

@piecanoe piecanoe Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. I'll remove that line and also change the text color of 'button' in index.css to '--color-white' so it applies to all buttons in both light and dark mode.

src/views/Layout.css Outdated Show resolved Hide resolved
Copy link
Collaborator

@krsnamara krsnamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment and suggestion to delete text

Copy link
Collaborator

@amalyam amalyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, looks really nice! One suggestion to bring app name and navbar items a little closer to the center, things feel a bit close to the edge and navbar items feel a bit far apart.

Also, sign out button looks right for me in chrome, but looks like this in fIrefox:
Screen Shot 2024-04-05 at 22 56 59

I'm not sure what's causing the difference between the two browsers, would have to do more digging. Maybe @mxmason has thoughts?

@amalyam
Copy link
Collaborator

amalyam commented Apr 6, 2024

update to comment above^: after setting the firefox window width to the narrowest it can be, the signout button looks fine, so I guess it's how the button is scaling up at full view? I also see now how setting the location of the app name and navbar items closer to the center might be tricky to have it both look good at the narrowest screen size and full view without getting into media queries, so probably doesn't make sense for now unless you wanted to play around with that if you have time.

@krsnamara krsnamara merged commit f0d3651 into main Apr 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design sprint design sprint from issue 14 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stylize the Navbar
3 participants