Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AM] Improve layout of list items and sub-sections #71

Merged
merged 15 commits into from
Apr 1, 2024

Conversation

amalyam
Copy link
Collaborator

@amalyam amalyam commented Mar 28, 2024

Description

This code cleans up the formatting of each list item and the sub-sections they are within. It adds spacing between the checkbox, item name, delete button, and buy next info, increases the size of the sub-section titles, and adds a horizontal line between each subsection. It also places each item name in an html tag for ease of global styling.

Related Issue

Closes #70
Sub-issue of #14

Acceptance Criteria

  • improves the readability of list items by adding space between the checkbox, item name, delete button, and buy next info
  • provides other formatting to make this section more user friendly

Updates

Before

Screen Shot 2024-03-28 at 18 17 50

After

Screen Shot 2024-03-28 at 21 59 03

@amalyam amalyam added enhancement New feature or request refactoring design sprint design sprint from issue 14 labels Mar 28, 2024
@amalyam amalyam self-assigned this Mar 28, 2024
Copy link

github-actions bot commented Mar 28, 2024

Visit the preview URL for this PR (updated for commit dd80637):

https://tcl-69-smart-shopping-list--pr71-am-fix-items-layout-i8sqhp9u.web.app

(expires Fri, 05 Apr 2024 01:59:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93172cc46147b7d365c2b1b8239b61e2efb07a80

@amalyam
Copy link
Collaborator Author

amalyam commented Mar 29, 2024

many thanks to @mxmason on this for debugging some spacing issues!

@amalyam amalyam marked this pull request as ready for review March 29, 2024 02:00
Copy link
Collaborator

@krsnamara krsnamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Doesn't break anything.

Wondering if we want to add flex-direction: column on the items to create a little break in the information.

Also it seems like we have a ton of space at this point, maybe the 'X' on delete button could say "Delete" or "Remove" and have its own line?
Can maybe workshop more in our next meeting.
I have a draft PR up with some styling. Started working on the global color variables and adding a font to use.

@piecanoe
Copy link
Collaborator

piecanoe commented Mar 30, 2024

Nice job--looks like it's working correctly!

I agree with Marty that maybe we can rework some of the spacing and move the delete button or 'Buy Next' to another line. Especially for a smaller window, it still looks quite crowded right now. More to chat about in the next meeting!

Screenshot 2024-03-29 170928

@piecanoe piecanoe requested review from rmorabia and mxmason March 30, 2024 00:12
@piecanoe piecanoe requested a review from louieknolle March 30, 2024 00:12
Copy link
Collaborator

@louieknolle louieknolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! And seems like y'all will be continuing to discuss the layout in a different PR.

@amalyam
Copy link
Collaborator Author

amalyam commented Apr 1, 2024

These are great thoughts, will merge for now and save these for another issue.

@amalyam amalyam merged commit 78434eb into main Apr 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design sprint design sprint from issue 14 enhancement New feature or request refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up display of list items and sub-lists
4 participants