-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AM] Improve layout of list items and sub-sections #71
Conversation
Visit the preview URL for this PR (updated for commit dd80637): https://tcl-69-smart-shopping-list--pr71-am-fix-items-layout-i8sqhp9u.web.app (expires Fri, 05 Apr 2024 01:59:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 93172cc46147b7d365c2b1b8239b61e2efb07a80 |
many thanks to @mxmason on this for debugging some spacing issues! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Doesn't break anything.
Wondering if we want to add flex-direction: column
on the items to create a little break in the information.
Also it seems like we have a ton of space at this point, maybe the 'X' on delete button could say "Delete" or "Remove" and have its own line?
Can maybe workshop more in our next meeting.
I have a draft PR up with some styling. Started working on the global color variables and adding a font to use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! And seems like y'all will be continuing to discuss the layout in a different PR.
These are great thoughts, will merge for now and save these for another issue. |
Description
This code cleans up the formatting of each list item and the sub-sections they are within. It adds spacing between the checkbox, item name, delete button, and buy next info, increases the size of the sub-section titles, and adds a horizontal line between each subsection. It also places each item name in an html tag for ease of global styling.
Related Issue
Closes #70
Sub-issue of #14
Acceptance Criteria
Updates
Before
After