Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AM] Change welcome text from "Box Makers" to "Aisle Be There" #67

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

amalyam
Copy link
Collaborator

@amalyam amalyam commented Mar 28, 2024

Description

Change text on landing page to display app name as "Aisle Be There". This change also adds some basic intro text to the landing page and CSS to format that text.

Related Issue

Closes #66
Sub-issue of #14

Acceptance Criteria

  • landing page displays app name as "Aisle Be There"
  • "Box Makers" no longer appears

Updates

Before

Screen Shot 2024-03-28 at 15 58 33

After

Screen Shot 2024-03-28 at 16 06 53

Testing Steps / QA Criteria

Check that landing page displays "Aisle Be There" and does not display "Box Makers" and the basic intro text pictured above.

Note

A future update might change the image to be more in line with new app name and future theme color.

@amalyam amalyam added enhancement New feature or request design sprint design sprint from issue 14 labels Mar 28, 2024
Copy link

github-actions bot commented Mar 28, 2024

Visit the preview URL for this PR (updated for commit 69bd0b9):

https://tcl-69-smart-shopping-list--pr67-am-change-app-name-dgvetk10.web.app

(expires Thu, 04 Apr 2024 20:07:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93172cc46147b7d365c2b1b8239b61e2efb07a80

@amalyam amalyam self-assigned this Mar 28, 2024
@amalyam amalyam marked this pull request as ready for review March 28, 2024 20:09
Copy link
Collaborator

@hsiangj hsiangj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@piecanoe
Copy link
Collaborator

Bye bye, Box Makers. This looks good to me.

Copy link
Collaborator

@krsnamara krsnamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge I'd say.

Copy link
Collaborator

@louieknolle louieknolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No notes! I'm always a fan of pun based naming conventions

@amalyam amalyam merged commit b349d95 into main Apr 1, 2024
2 checks passed
@amalyam amalyam deleted the am-change-app-name branch April 1, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design sprint design sprint from issue 14 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change App Name on Landing Page
5 participants