-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KD] Reduce List Items Label Size #39
Conversation
Visit the preview URL for this PR (updated for commit 1db3ce0): https://tcl-69-smart-shopping-list--pr39-kd-reduce-list-items-nooii9t7.web.app (expires Wed, 27 Mar 2024 18:34:31 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 93172cc46147b7d365c2b1b8239b61e2efb07a80 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nit: create .css file for List.jsx styling
src/components/ListItem.css
Outdated
@@ -1,8 +1,9 @@ | |||
.ListItem { | |||
align-items: baseline; | |||
display: flex; | |||
display: inline; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 display: inline-flex
might accomplish what you want here without getting rid of some of the benefits of flex layout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I'll make that change!
Description
Items on 'List' page often get checked off when user clicks in the blank spaces on the page. This code reduces the size of each list item's label size to prevent accidental ticking of the item checkboxes. The cursor will also change to a hand pointer when hovering over a "checkable" item
Related Issue
Closes #36
Sub-issue of #14
Acceptance Criteria
Type of Changes
Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g.,
bug fix
orenhancement
are common ones.Updates
Before
After
Testing Steps / QA Criteria