Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KD] Reduce List Items Label Size #39

Merged
merged 6 commits into from
Mar 20, 2024
Merged

Conversation

piecanoe
Copy link
Collaborator

@piecanoe piecanoe commented Mar 20, 2024

Description

Items on 'List' page often get checked off when user clicks in the blank spaces on the page. This code reduces the size of each list item's label size to prevent accidental ticking of the item checkboxes. The cursor will also change to a hand pointer when hovering over a "checkable" item

Related Issue

Closes #36
Sub-issue of #14

Acceptance Criteria

  • Reduce size of the item labels to reduce the chance of accidentally checking off items.
  • Add indicator to show user when they are hovering over a checkable item on the list.

Type of Changes

Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g., bug fix or enhancement are common ones.

Updates

Before

before_1

After

after_1

Testing Steps / QA Criteria

  1. From home, click on a list that already has items.
  2. Hover over the empty space directly to the right of the items. Try clicking. Your cursor should not change and you should not be able to check off any items.
  3. Hover over one of the items. Your pointer should change into a hand pointer and the checkbox border should change color indicating the ability to check off the item. Click to check off the item.

Copy link

github-actions bot commented Mar 20, 2024

Visit the preview URL for this PR (updated for commit 1db3ce0):

https://tcl-69-smart-shopping-list--pr39-kd-reduce-list-items-nooii9t7.web.app

(expires Wed, 27 Mar 2024 18:34:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93172cc46147b7d365c2b1b8239b61e2efb07a80

@piecanoe piecanoe changed the title [KD] Reduce List Items Size [KD] Reduce List Items Label Size Mar 20, 2024
@piecanoe piecanoe added enhancement New feature or request design sprint design sprint from issue 14 suggestion a suggestion for a new issue labels Mar 20, 2024
@piecanoe piecanoe self-assigned this Mar 20, 2024
@piecanoe piecanoe marked this pull request as ready for review March 20, 2024 16:31
Copy link
Collaborator

@krsnamara krsnamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nit: create .css file for List.jsx styling

@@ -1,8 +1,9 @@
.ListItem {
align-items: baseline;
display: flex;
display: inline;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 display: inline-flex might accomplish what you want here without getting rid of some of the benefits of flex layout.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I'll make that change!

@piecanoe piecanoe merged commit b77ed12 into main Mar 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design sprint design sprint from issue 14 enhancement New feature or request suggestion a suggestion for a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user, I want to be able to click between empty spaces on the page without unintended checkbox toggling.
4 participants