[MF] Adding Router to List Name Buttons on Home Screen #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This code imports React Router Dom Link component into the SingleList.jsx file. The Link component wraps the button in the single list with the "/list" endpoint. This changes each list item on the Home screen so that now when selecting a list you are routed to that specific list page. There is some lag in waiting for the listPath to return the promise and show the correct items. This could be resolved with some kind of loading spinner in a future issue. You can see that the listPath is already passed to the List component in that the name in the greeting matches the specific List the User selects.
Related Issue
closes #31
sub-issue of #14
Acceptance Criteria
Type of Changes
Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g.,
bug fix
orenhancement
are common ones.Updates
Before
Screen.Recording.2024-03-14.at.5.41.30.PM.mov
After
UI has changed a little with the default styling of and
Screen.Recording.2024-03-14.at.5.41.30.PM.mov
Testing Steps / QA Criteria