feat(mysql): add isRoot parameter to executeQuery
#882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| const queryResult = await container.executeQuery("SELECT 1 as res"); | ||
| expect(queryResult).toEqual(expect.stringContaining("res\n1\n")); | ||
|
|
||
| // Test root user | ||
| const rootQueryResult = await container.executeQuery("SELECT CURRENT_USER() as user"); |
There was a problem hiding this comment.
How does this test test the new isRoot parameter? Also please add a separate test
There was a problem hiding this comment.
Here we go, fixed. I apologise for the incomplete PR, I don't know what happened.
I kept the "test non-root and root in the same test" approach as is done in the "should work with database URI" test
cristianrgreco
added
enhancement
jeengbe
force-pushed
the
je-mysql-execute-query-root
branch
from
da1a560 to
b8118db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's convenient to be able to perform root operations directly on the container. The parameter is optional and defaults to the current behaviour, so it's no breaking change.