Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove lifecycle policy references from public ECR examples #43

Merged

Conversation

zahorniak
Copy link
Contributor

Description

Public ECR doesn't support the Lifecycle policy, so I removed it from Readme and the example code.

Motivation and Context

Closes #38

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs changed the title docs: Update Readme and example code docs: Remove lifecycle policy references from public ECR examples May 28, 2024
@bryantbiggs bryantbiggs merged commit df965a8 into terraform-aws-modules:master May 28, 2024
7 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2024
@antonbabenko
Copy link
Member

This PR is included in version 2.3.0 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECR public repo doesn't support lifecycle policy
3 participants