Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add tags variable to public registry resource #40

Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix: Add tags variable to public registry resource #40

merged 2 commits into from
Apr 17, 2024

Conversation

bryantbiggs
Copy link
Member

Description

  • Add tags variable to public registry resource

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

antonbabenko
antonbabenko approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's not remove unused providers hook since it is not working in many cases of our modules.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
@bryantbiggs bryantbiggs merged commit 27f4867 into terraform-aws-modules:master Apr 17, 2024
6 checks passed
@bryantbiggs bryantbiggs deleted the fix/tags branch April 17, 2024 22:45
antonbabenko pushed a commit that referenced this pull request Apr 17, 2024
@semantic-release-bot
chore(release): version 2.2.1 [skip ci]
9daab07 
## [2.2.1](v2.2.0...v2.2.1) (2024-04-17)

### Bug Fixes

* Add tags variable to public registry resource ([#40](#40)) ([27f4867](27f4867))
@antonbabenko
Copy link
Member

This PR is included in version 2.2.1 🎉

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public ECR Resource is missing TAG attribute
2 participants
@bryantbiggs @antonbabenko