Keep up with Audacity's library separation efforts (part 1) #656
Conversation
|
Thank you for working on this but unilaterally declaring you will merge in a very short timespan without review is inappropriate. This is a large change, +1,830 −341, that warrants more than such a rushed process. |
Got it, will remove that part. |
|
It looks like there are a few commits in the beginning which are already in the master branch? Please do an interactive rebase to remove those. |
|
I was afraid that people weren't checking this, so it was like, "okay, I might as well spearhead this on my own for a bit". There's a small mistake where I accidentally signed some changes that weren't mine, fixing this right now. |
|
I have added the |
n0toose
force-pushed
the
panos/library-separation
branch
from
ff1d0a5 to
b17994b
Compare
|
Most of these changes were pulled as-is from the Audacity tree. I stopped at the part where I had to also split lib-basic-ui further (which is when the further library separations took place) because it'd make everything much more complex. |
|
Seriously wondering why the Windows builds specifically are failing. Doesn't seem like a CI issue. |
n0toose
force-pushed
the
panos/library-separation
branch
from
b17994b to
03535e7
Compare
|
Force-pushed. I took advantage of this opportunity to replace a single documented reference of |
n0toose
force-pushed
the
panos/library-separation
branch
from
03535e7 to
c86c958
Compare
n0toose
changed the title
Based off the work of Paul and adapted for Tenacity. Original commit: 54b5f7d Co-authored-by: Paul Licameli <[email protected]> Signed-off-by: Panagiotis Vasilopoulos <[email protected]>
Original commit: ab30511 Signed-off-by: Panagiotis Vasilopoulos <[email protected]>
... as suggested by Sampo Hippeläinen. Original commit: 3ebebbb Signed-off-by: Panagiotis Vasilopoulos <[email protected]>
We don't need many of these imported strings, because we don't have crash reports or updates. Commit imported from d20cf01 Co-authored-by: Paul Licameli <[email protected]> Signed-off-by: Panagiotis Vasilopoulos <[email protected]>
Original commit: 060885c Signed-off-by: Panagiotis Vasilopoulos <[email protected]>
Useful for eliminating many direct mentions of wxString. We added this patch from Audacity because it coincides with our goal of becoming more platform agnostic. Original commits: - cfbdd2d - 132f04d Signed-off-by: Panagiotis Vasilopoulos <[email protected]>
... but none of the methods is defined yet. The intention is to inject dependencies on wxWidgets (or other) toolkit so that lower-level files have less build dependency on wxCore classes or on the event loop. Original commit: d20cf01 Signed-off-by: Panagiotis Vasilopoulos <[email protected]>
...so direct uses of wx/app.h may later be removed. That header is one of the files that is in wxBase, but is not acceptable in "toolkit neutral" code, which should not directly use any version of an event loop. Original commit: 50e8139 Signed-off-by: Panagiotis Vasilopoulos <[email protected]>
... An elaborate way to hold a wxWindow* as parent of a window, but avoiding mention of wxWindow* in the member functions of BasicUI::Services, to be defined next Original commit: 2facbe0 Signed-off-by: Panagiotis Vasilopoulos <[email protected]>
Signed-off-by: Panagiotis Vasilopoulos <[email protected]>
Patch imported by Audacity and adapted for Tenacity. Original commit: 6477c9e0a6cb93b781c6c83153f1d036a7cc4c13 Signed-off-by: Panagiotis Vasilopoulos <[email protected]>
n0toose
force-pushed
the
panos/library-separation
branch
from
c86c958 to
0843918
Compare
Initial work with cherry-picking for the sake of keeping up with Audacity's efforts of separating libraries and maintaining compatibility.
If you wish to review this pull request, please check if I've accidentally added a part of their project that we do not want (e.g. Sentry reports) or if I've accidentally removed something ours.
Checklist
-sorSigned-off-by* (See: Contributing § DCO)* indicates required