Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding namespace handover test case for history executable #7047

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding namespace handover test case for history executable #7047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions service/history/queues/executable_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,10 @@
name: "ErrDeleteOpenExecErr",
taskErr: consts.ErrDependencyTaskNotCompleted, // this error won't trigger re-submit
},
{
name: "ErrNamespaceHandOver",
taskErr: consts.ErrNamespaceHandOver, // this error won't trigger re-submit

Check failure on line 800 in service/history/queues/executable_test.go

View workflow job for this annotation

GitHub Actions / golangci 

undefined: consts.ErrNamespaceHandOver (typecheck)

Check failure on line 800 in service/history/queues/executable_test.go

View workflow job for this annotation

GitHub Actions / Unit test 

undefined: consts.ErrNamespaceHandOver

Check failure on line 800 in service/history/queues/executable_test.go

View workflow job for this annotation

GitHub Actions / Unit test 

undefined: consts.ErrNamespaceHandOver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
taskErr: consts.ErrNamespaceHandOver, // this error won't trigger re-submit
taskErr: consts.ErrNamespaceHandover, // this error won't trigger re-submit

},
}

for _, tc := range testCases {
Expand Down
Loading