Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for golang catalog #5

Merged

Conversation

QuanZhang-William
Copy link
Collaborator

@QuanZhang-William QuanZhang-William commented Jan 26, 2023

This commit adds test cases for golang catalog. Golang catalog test script will be sent out separately after tektoncd/plumbing#1323 is merged.

A tested e2e example can be found in: https://github.com/QuanZhang-William/golang/tree/test-pipelines

@QuanZhang-William
Copy link
Collaborator Author

cc @vdemeester @vinamra28

@QuanZhang-William
Copy link
Collaborator Author

Part of #3

@QuanZhang-William
Copy link
Collaborator Author

@vdemeester @vinamra28

I'm not sure whether we need some extra setup in the cluster if we want to use custom GOARCH param (like s390x or ppc64le)? This seems like a potential use case of matrix as documented here

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether we need some extra setup in the cluster if we want to use custom GOARCH param (like s390x or ppc64le)? This seems like a potential use case of matrix as documented here

We can use GOARCH in any cluster, no need for extra setup, it's all handled by the go compiler.

@QuanZhang-William
Copy link
Collaborator Author

I'm not sure whether we need some extra setup in the cluster if we want to use custom GOARCH param (like s390x or ppc64le)? This seems like a potential use case of matrix as documented here

We can use GOARCH in any cluster, no need for extra setup, it's all handled by the go compiler.

Sounds good, I will try to dogfood matrix in this case.
/cc @jerop

@QuanZhang-William QuanZhang-William merged commit 4485a95 into tektoncd-catalog:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants