Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue templates #1

Closed
wants to merge 1 commit into from
Closed

Conversation

QuanZhang-William
Copy link
Collaborator

@QuanZhang-William QuanZhang-William commented Jan 10, 2023

This commit adds the GitHub issue templates (Bug report & Feature request) and PR template as required in: https://github.com/tektoncd/community/blob/main/process.md#project-requirements

The issue templates are copied from: https://github.com/tektoncd/pipeline
The PR template is copied from: https://github.com/tektoncd/catalog

@QuanZhang-William
Copy link
Collaborator Author

QuanZhang-William commented Jan 10, 2023

Part of #3

This commit adds the GitHub issue templates (`Bug report` & `Feature request`) and PR template as required in: https://github.com/tektoncd/community/blob/main/process.md#project-requirements

The issue templates are copied from: https://github.com/tektoncd/pipeline
The PR templates are copied from: https://github.com/tektoncd/catalog
@QuanZhang-William
Copy link
Collaborator Author

/cc @dibyom @vdemeester @vinamra28

These are the criteria that every PR should meet, please check them off as you
review them:

TODO: add submitter checklist details

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably you can copy from current catalog repository

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing here is that we can be way more specific than on tektoncd/catalog. We know it's only about golang, etc.. so we could get the initial checklist from the catalog repository but we may want to adapt.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I will use the content in the current catalog repository as a starting point. And there are some improvement and link updates that we need to do (like the golang specific checks, update the e2e test link once the contributing doc is ready...) so that's why I leave it as todo for now. Will send out PR to fill in the content later if you don't mind 😁

These are the criteria that every PR should meet, please check them off as you
review them:

TODO: add submitter checklist details
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing here is that we can be way more specific than on tektoncd/catalog. We know it's only about golang, etc.. so we could get the initial checklist from the catalog repository but we may want to adapt.

@QuanZhang-William
Copy link
Collaborator Author

close this PR as we have: tektoncd-catalog/.github#1

@vinamra28 vinamra28 deleted the update-issue-templates branch January 14, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants