Temporal: Tests for correct intermediate value in ZonedDateTime difference/rounding #4012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
force-pushed
the
temporal-2760
branch
from
a3f54a8 to
831a285
Compare
Ms2ger
approved these changes
Feb 22, 2024
...-ins/Temporal/Duration/prototype/add/differencezoneddatetime-inconsistent-custom-calendar.js
Outdated
Show resolved
Hide resolved
ptomato
force-pushed
the
temporal-2760
branch
from
831a285 to
a0cf208
Compare
ptomato
force-pushed
the
temporal-2760
branch
from
a0cf208 to
9ebabaf
Compare
9 tasks
|
I'm expecting there may be more comments on the normative PR, so this may get updated as well. |
|
I don't expect any more comments on the normative PR, so this is ready as far as I'm concerned. The two tests named I'll plan to merge this Monday unless anyone hollers. |
…rence/rounding These test cases ensure that DST disambiguation does not take place on intermediate values that are not the start or the end of the calculation. Note that NormalizedTimeDurationToDays is no longer called inside Temporal.Duration.prototype.add/subtract, so a few tests can be deleted. Other tests need to be adjusted because NormalizedTimeDurationToDays is no longer called inside Temporal.ZonedDateTime.prototype.since/until via DifferenceZonedDateTime, although it is still called as part of rounding. In addition, new tests for the now-fixed edge case are added, and for the day corrections that can happen to intermediates. See tc39/proposal-temporal#2760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test cases ensure that DST disambiguation does not take place on intermediate values that are not the start or the end of the calculation.
Note that NormalizedTimeDurationToDays is no longer called inside Temporal.Duration.prototype.add/subtract, so a few tests can be deleted.
Other tests need to be adjusted because NormalizedTimeDurationToDays is no longer called inside Temporal.ZonedDateTime.prototype.since/until via DifferenceZonedDateTime, although it is still called as part of rounding.
In addition, new tests for the now-fixed edge case are added.
See tc39/proposal-temporal#2760, a normative change approved in the TC39 plenary of 2024-02.