Add tests for precise results in Duration.p.total and ZonedDateTime.p.hoursInDay #3978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….hoursInDay The existing tests didn't cover some edge cases where implementations have to compute the exact result of `numerator / denominator`, where at least one of `numerator` and `denominator` can't be exactly represented by an IEEE-754 double precision floating point value. "precision-exact-mathematical-values-5.js" gets added in tc39#3961, so the new tests from this commit start at "precision-exact-mathematical-values-6.js".
anba
force-pushed
the
temporal-fraction-precision
branch
from
de53aca to
110203b
Compare
ptomato
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Thanks as always for the number precision tests.
I've checked these against the state of the Temporal proposal including tc39/proposal-temporal#2727, which is not merged yet. So I'll close this PR and have absorbed it into #3961.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 16, 2024
…al and ZonedDateTime.p.hoursInDay. r=dminor Required to pass the tests from <tc39/test262#3978>. Differential Revision: https://phabricator.services.mozilla.com/D198556
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Apr 17, 2024
…al and ZonedDateTime.p.hoursInDay. r=dminor Required to pass the tests from <tc39/test262#3978>. Differential Revision: https://phabricator.services.mozilla.com/D198556
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing tests didn't cover some edge cases where implementations have to compute the exact result of
numerator / denominator, where at least one ofnumeratoranddenominatorcan't be exactly represented by an IEEE-754 double precision floating point value."precision-exact-mathematical-values-5.js" gets added in #3961, so the new tests from this commit start at "precision-exact-mathematical-values-6.js".