Test closing async-from-sync iterator when resolving result promise abrupt completes. #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
reviewed
Dec 31, 2023
test/built-ins/AsyncFromSyncIteratorPrototype/throw/throw-result-poisoned-wrapper.js
Outdated
Show resolved
Hide resolved
bakkot
approved these changes
Dec 31, 2023
test/built-ins/AsyncFromSyncIteratorPrototype/throw/throw-result-poisoned-wrapper.js
Outdated
Show resolved
Hide resolved
ptomato
approved these changes
Jan 13, 2024
There was a problem hiding this comment.
👍 when @nicolo-ribaudo's comment has been addressed. (Just as in part 1, you might consider using the async helpers to simplify the tests, but that's optional.)
|
@ptomato refactored tests as in part 1. |
…brupt completes. These test new steps 6-6.a of AsyncFromSyncIteratorContinuation as per normative changes of ecma626 PR 2600 tc39/ecma262#2600
Co-authored-by: Kevin Gibbons <[email protected]>
Co-authored-by: Nicolò Ribaudo <[email protected]>
ptomato
force-pushed
the
async-from-sync-iterator-close-tests-abrupt-valueWrapper
branch
from
167163e to
92d20c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These test new steps 6-6.a of AsyncFromSyncIteratorContinuation as per normative changes of ecma626 PR 2600
tc39/ecma262#2600
2nd of 3 patches to fix #3387
All these tests are based on @jridgewell 's comment