Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for firstDayOfWeek in LocaleInfo PR 70 #3924

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Add test for firstDayOfWeek in LocaleInfo PR 70 #3924

merged 1 commit into from
Nov 11, 2023

Conversation

FrankYFTang
Copy link
Contributor

Test for enhancement in
tc39/proposal-intl-locale-info#70

@FrankYFTang FrankYFTang requested a review from a team as a code owner September 15, 2023 20:53
@FrankYFTang FrankYFTang mentioned this pull request Sep 15, 2023
Merged
@FrankYFTang
Copy link
Contributor Author

please add "awaiting specification" label

@FrankYFTang
Copy link
Contributor Author

PR70 is merged after reach consensus on TC39 2023-09-26 meeting.

@FrankYFTang
Copy link
Contributor Author

Please review and merge. Thanks

@ptomato ptomato added needs review has consensus This has committee consensus and removed awaiting specification labels Sep 26, 2023
ptomato
ptomato approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ptomato ptomato enabled auto-merge (rebase) November 11, 2023 01:09
@ptomato
Copy link
Contributor

ptomato commented Nov 11, 2023

For some reason, GitHub is acting weird about displaying the status. I hope the PR will merge itself eventually with auto-merge enabled.

@ptomato ptomato force-pushed the addFWLocaleInfo branch 2 times, most recently from 75164e0 to ee13e77 Compare November 11, 2023 02:08
@ptomato ptomato merged commit 96727ca into tc39:main Nov 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptomato ptomato ptomato approved these changes

Assignees
No one assigned
Labels
has consensus This has committee consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankYFTang @ptomato