-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: Explicitly designate sort order for plural categories returned by Intl.PluralRules.prototype.resolvedOptions #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strings in _pluralCategories_ List in Intl.PluralRules.prototype.resolvedOptions()
eemeli
approved these changes
Aug 21, 2024
ben-allen
added
normative
needs consensus
s: discuss
Status: TG2 must discuss to move forward
labels
Aug 22, 2024
I believe this is presented to Oct TC39 meeting and still waiting for Mozilla to express their opinion. |
Mozilla expressed approval on the second day of the Oct 24 TC39 plenary |
ben-allen
added
has consensus (TG1)
Has consensus from TC39-TG1
needs tests
and removed
needs consensus
s: discuss
Status: TG2 must discuss to move forward
labels
Oct 11, 2024
ben-allen
added a commit
to ben-allen/test262
that referenced
this pull request
Oct 21, 2024
…egories` order Array elements should appear in following order: "zero", "one", "two", "few", "many", "other" see tc39/ecma402#918
ben-allen
added a commit
to ben-allen/test262
that referenced
this pull request
Oct 21, 2024
…egories` order Array elements should appear in following order: "zero", "one", "two", "few", "many", "other" see tc39/ecma402#918
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Nov 5, 2024
Explicitly designate sort order for plural categories returned by Intl.PluralRules.prototype.resolvedOptions Spec tc39/ecma402#918 Bug: 372722562 Change-Id: I3aea0395446cfc0d4950d7591fd4b1b2bd725e5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5923607 Reviewed-by: Ilya Rezvov <[email protected]> Reviewed-by: Shu-yu Guo <[email protected]> Reviewed-by: Frank Tang <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/main@{#96991}
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Nov 26, 2024
…olvedOptions. r=spidermonkey-reviewers,dminor Sort plural categories per <tc39/ecma402#918>. Tests are in <tc39/test262#4275>. Differential Revision: https://phabricator.services.mozilla.com/D228569
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 27, 2024
…olvedOptions. r=spidermonkey-reviewers,dminor Sort plural categories per <tc39/ecma402#918>. Tests are in <tc39/test262#4275>. Differential Revision: https://phabricator.services.mozilla.com/D228569
Ms2ger
pushed a commit
to ben-allen/test262
that referenced
this pull request
Dec 3, 2024
…egories` order Array elements should appear in following order: "zero", "one", "two", "few", "many", "other" see tc39/ecma402#918
Ms2ger
pushed a commit
to tc39/test262
that referenced
this pull request
Dec 3, 2024
…egories` order (#4275) Array elements should appear in following order: "zero", "one", "two", "few", "many", "other" see tc39/ecma402#918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
has consensus (TG1)
Has consensus from TC39-TG1
has consensus
Has consensus from TC39-TG2
needs tests
normative
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #578
This change follows the ordering suggested by @zbraniecki in #578 (comment)