-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freemine.cmake.external.proj #29455
Open
freemine
wants to merge
21
commits into
taosdata:main
Choose a base branch
from
freemine:freemine.cmake.external.proj
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Freemine.cmake.external.proj #29455
+340
−1,583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. remove utils/TSZ/.../xxhash.c,xxhash.h because same xxhash.c/xxhash.h exist in contrib/lzma/...
btw, currently, this PR only tested under linux, not including windows or macosx yet. |
tomchon
requested review from
stephenkgu,
guanshengliang and
yihaoDeng
and removed request for
stephenkgu and
guanshengliang
January 3, 2025 08:50
2. link with static library of zlib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
with the hope of clarifying building system of TDengine itself, to isolate source code, external project and building-binaries, so that further work, such as test-cases-running, rebuilding among branches, could be simplied and less error prone.
this is still in early stage, and /contrib directory is still containing both source-code and downloaded external projects and there-built-binaries. but it's believed easy to isolate them later on.
wish you guys might think this potentially useful, and looking forward to your comments.
Checklist
Please check the items in the checklist if applicable.