[Feature] #567643 - new DSUserAvatar customization #246
Conversation
| const SizedBox( | ||
| height: 15, | ||
| ), | ||
| DSHeadlineExtraLargeText( |
There was a problem hiding this comment.
Could put this one (and the above) inside the already existing SampleTextStyleShowcase widget.
| @@ -331,6 +331,7 @@ class DSCard extends StatelessWidget { | |||
| style: style, | |||
| shouldAuthenticate: shouldAuthenticate, | |||
| isUploading: isUploading, | |||
| // Devo criar um parametro novo no DSFileMessageBubble que será o texto da mensagem? Só depois instanciá-lo aqui no caso. | |||
There was a problem hiding this comment.
I think that you forgot to remove this comment.
| super.fontStyle, | ||
| super.shouldLinkify, | ||
| super.isSelectable, | ||
| super.height = 1.4, |
There was a problem hiding this comment.
According to Design specifications, this height should be 1.25.
| super.fontStyle, | ||
| super.shouldLinkify, | ||
| super.isSelectable, | ||
| super.height = 1.4, |
There was a problem hiding this comment.
According to Design specifications, this height should be 1.25.
| import '../utils/ds_font_weights.theme.dart'; | ||
| import 'ds_text_style.theme.dart'; | ||
|
|
||
| /// A Design System's [TextStyle] primarily used by large titles. |
There was a problem hiding this comment.
Update this comment to [...] used by extra large titles.
| }); | ||
| this.textColor = DSColors.neutralDarkCity, | ||
| TextStyle textStyle = const DSBodyTextStyle(), | ||
| }) : textStyle = textStyle.apply( |
There was a problem hiding this comment.
Since TextStyle already has a color parameter, you could get rid of the textColor prop to avoid duplicity. Then, my suggestion would be to use the Merge method from TextStyle so you can assure the usage of default values in case they aren't passed through textStyle prop:
static const _defaultTextStyle = TextStyle(
color: DSColors.neutralDarkCity,
overflow: TextOverflow.clip,
);: textStyle = _defaultTextStyle.merge(textStyle)
This PR aims to add new style options to the DSUserAvatar widget in the app.
A sample file was also created to assure the new style feature can work with the afore mentioned Avatar.