Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript 5.5.4 → 5.6.3 (minor) #14680

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
+38 −39
Open

Update typescript 5.5.4 → 5.6.3 (minor) #14680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d20e021
Update typescript to version 5.6.3
depfu[bot] Oct 16, 2024
f80c9dc
Remove `verbatimModuleSyntax` from default TS config
philipp-spiess Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"prettier-plugin-organize-imports": "^4.0.0",
"tsup": "^8.2.4",
"turbo": "^2.1.3",
"typescript": "^5.5.4",
"typescript": "^5.6.3",
"vitest": "^2.0.5"
},
"packageManager": "[email protected]",
Expand Down
1 change: 0 additions & 1 deletion packages/tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

"moduleResolution": "Bundler",
"allowImportingTsExtensions": true,
"verbatimModuleSyntax": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax

As far as I understand this, this option was not supposed to ever work and translate common JS files but we are using it like this right now in our .cts file. The docs suggest using a syntax like this instead:

import foo = require('foo');

export = {
  foo
}

We use the export = syntax already but changing the import accordingly breaks with another TS issue:

│ src/compat/colors.cts(1,1): error TS1202: Import assignment cannot be used when targeting EC
│ MAScript modules. Consider using 'import * as ns from "mod"', 'import {a} from "mod"', 'impo
│ rt d from "mod"', or another module format instead.

I don't know how to fix this other than removing verbatimModuleSyntax unfortunately 😞 cc @tailwindlabs/engineering

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @RobinMalfait @thecrypticace what are your thoughts?

"isolatedModules": true,
"preserveConstEnums": true,
"noEmit": true,
Expand Down
2 changes: 1 addition & 1 deletion playgrounds/nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
"@types/react-dom": "^18.3.0",
"eslint": "^9.11.1",
"eslint-config-next": "^14.2.5",
"typescript": "^5.5.4"
"typescript": "^5.6.3"
}
}
72 changes: 36 additions & 36 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.