Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrades to start-database.sh #2038

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

acharlop
Copy link

@acharlop acharlop commented Dec 3, 2024

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

In start-database.sh some variables are built from DATABASE_URL and some aren't. This PR changes that so all variables are built from it.

  • DB_NAME added
  • DB_CONTAINER_NAME uses "$DB_NAME-postgres"

Screenshots

[Screenshots]

💯

Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: 10d605e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 9:43pm

Copy link

vercel bot commented Dec 3, 2024

@acharlop is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@acharlop
Copy link
Author

acharlop commented Dec 3, 2024

Might have broken your CI pipeline with this 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant