Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates react-native-ldk #1982

Merged
merged 1 commit into from
Jun 12, 2024
Merged

chore: updates react-native-ldk #1982

merged 1 commit into from
Jun 12, 2024

Conversation

Jasonvdb
Copy link
Collaborator

Description

Updates react-native-ldk to include restart fixes for iOS synonymdev/react-native-ldk#249

Linked Issues/Tasks

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Insert relevant screenshot / recording

QA Notes

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce during the Bitkit testing session. You can also leave a video of the PR in action.

@Jasonvdb Jasonvdb requested a review from pwltr June 12, 2024 13:33
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@synonymdev/[email protected] None 0 0 B
npm/@types/[email protected] None 0 8.36 kB types
npm/[email protected] None 0 808 kB aearly
npm/[email protected] None 0 99 kB fanatid
npm/[email protected] None 0 3.52 kB indutny
npm/[email protected] environment, filesystem, shell 0 173 kB abetomo
npm/[email protected] None 0 23.1 kB dougwilson
npm/[email protected] None 0 6.09 kB samverschueren
npm/[email protected] None 0 413 kB feedic
npm/[email protected] None 0 189 kB mysticatea
npm/[email protected] None 0 12.8 kB ljharb
npm/[email protected] filesystem 0 3.01 kB sindresorhus
npm/[email protected] None 0 29.3 kB oss-bot
npm/[email protected] None 0 1.55 kB cwmma
npm/[email protected] None 0 298 kB suguru03
npm/[email protected] environment Transitive: filesystem +1 20.4 kB isaacs
npm/[email protected] network 0 122 kB lpinca

🚮 Removed packages: npm/@jest/[email protected], npm/@jest/[email protected], npm/@nodelib/[email protected], npm/@synonymdev/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note
Install scripts npm/[email protected]
  • Install script: install
  • Source: npm run build || echo "secp256k1 bindings compilation fail. Pure JS implementation will be used."

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@Jasonvdb Jasonvdb merged commit 3e606f2 into master Jun 12, 2024
5 of 6 checks passed
@Jasonvdb Jasonvdb deleted the rn-ldk-update branch June 12, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants