Simplify geo_factors_codegen w/ skip_dir_nesting #295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
geo_factors_codegen.py
was using an ad-hoc system ofgenerating all the C++ factors into a
factors
folder. It did this bycalling
Codegen.generate_function
to generate the code into atemporary file, read the file into a string, then re-wrote the string
into the desired location. I assume this was to avoid all the fluff
that's generated by default with
Codegen.generate_function
.However, there is the
skip_directory_nesting
optional argument forCodegen.generate_function
which does precisely that (I think the codein this file might have been written before that option was added).
So, to reduce confusion (such as the confusion I faced when I first
started looking at this file) and complexity, I rewrote the code to
instead use the
skip_directory_nesting
argument.Topic: geo_factors_use_skip_directory_nesting