-
Notifications
You must be signed in to change notification settings - Fork 150
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add versioned dev_requirements for py 3.8 3.9 3.10
Different version of python have different dev requirements. Previously, `dev_requirements.txt` was generated for python3.8 and assumed to work for other versions of python. That was more or less a safe assumption, except is now causing problems. Specifically, gtsam is not available on python 3.10, but we'd like to add it as a dev requirement for python 3.8 and 3.9. `symforce_requirements_test.py` cannot be run until symforce has been installed, but one might reasonably want to `pip install -r dev_requirements.txt` before installing symforce (to use the pinned build depencies during installation). To make this circular dependency less painful for the user, I'm adding - `dev_requirements_38.txt` - `dev_requirements_39.txt` - `dev_requirements_310.txt` so that the correct dev requirements can be installed before symforce installation for any supported python version. Modified `test/symforce_requirements_test.py` to only test/update the `dev_requirements_XY.txt` of the python version being used. Since the public CI is already running this test, it will guarentee that none of these files will go out of date. Needed to amend both ci.yml and docs.yml to use the correct `dev_requirements_XY.txt`. Also needed to update the `README.md` accordingly.
- Loading branch information
1 parent
559e521
commit 853fc03
Showing
7 changed files
with
761 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.