Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flex recipe for SuluFormBundle #995

Merged
3 commits merged into from
Sep 8, 2020
Merged

Add flex recipe for SuluFormBundle #995

3 commits merged into from
Sep 8, 2020

Conversation

luca-rath
Copy link
Contributor

Q A
License MIT

Link to package: https://github.com/sulu/SuluFormBundle

ghost
ghost approved these changes Aug 28, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@luca-rath luca-rath marked this pull request as draft August 28, 2020 10:30
ghost
ghost approved these changes Aug 28, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost
ghost approved these changes Aug 28, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@luca-rath luca-rath marked this pull request as ready for review August 28, 2020 10:49
ghost
ghost approved these changes Aug 28, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@luca-rath
Copy link
Contributor Author

ping @alexander-schranz

@alexander-schranz
Copy link
Contributor

alexander-schranz commented Aug 28, 2020 •
edited
Loading

@nicolas-grekas the CI is currently failing because in sulu the project need to define which phpcr/phpcr-implementation it will use. Not sure if there is any way to detect that. Maybe by checking the "composer.json" of the bundle/library has jackalope/jackalope-doctrine-dbal or jackalope/jackalope-jackrabbit in its "require-dev" like here and then run e.g.:

composer require jackalope/jackalope-doctrine-dbal --no-update

Before running composer install script.

@Nyholm
Copy link
Member

Nyholm commented Sep 8, 2020

It is really tricky to find virtual packages. No worries about the CI failures.

Nyholm
Nyholm approved these changes Sep 8, 2020
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

sulu/form-bundle/2.0/config/packages/sulu_form.yaml Show resolved Hide resolved
@ghost ghost merged commit aa48383 into symfony:master Sep 8, 2020
@luca-rath luca-rath deleted the feature/sulu-form-bundle branch September 9, 2020 08:40
@luca-rath luca-rath mentioned this pull request Mar 23, 2021
Merged
@wachterjohannes wachterjohannes mentioned this pull request Apr 22, 2021
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-schranz alexander-schranz alexander-schranz approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luca-rath @alexander-schranz @Nyholm