cs capitalise date abbr_month_names, day_names, month_names #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst it is correct that Czech (cs) does not capitalise day or month names appearing in the middle of a sentence, there is a choice when it comes to abbreviated or full days or months appearing on their own, in a menu or chart, etc. `date.abbr_day_names` used initial capitals, but `date.abbr_month_names`, `date.day_names`, `date.month_names` did not. Whichever style is used should likely be standardised, particularly between `date.abbr_day_names` and `date.abbr_month_names`. The translations for Slovak (sk), a close language in the same family with similar (but by no means identical) grammar, use initial capitals for all these day and month translations. Standardise these day and month translations to use initial capitals. Note I am not a native Czech speaker. However, I work a lot with multilingual translations, and checked this matter with a professional native Czech translator working for me. Their opinion was that both initial capital and lowercase translations are acceptable, but that an initial capital was more common and felt more natural. I also checked this with a native Slovak speaker who is also fluent in Czech, and they had the same opinion. Greetings from Prague!
sunny
approved these changes
Nov 20, 2023
|
Thanks! Done. |
|
Is anything else needed for this, @sunny ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst it is correct that Czech (cs) does not capitalise day or month names appearing in the middle of a sentence, there is a choice when it comes to abbreviated or full days or months appearing on their own, in a menu or chart, etc.
date.abbr_day_namesused initial capitals, butdate.abbr_month_names,date.day_names,date.month_namesdid not. Whichever style is used should likely be standardised, particularly betweendate.abbr_day_namesanddate.abbr_month_names.The translations for Slovak (sk), a close language in the same family with similar (but by no means identical) grammar, use initial capitals for all these day and month translations.
Standardise these day and month translations to use initial capitals.
Note I am not a native Czech speaker. However, I work a lot with multilingual translations, and checked this matter with a professional native Czech translator working for me. Their opinion was that both initial capital and lowercase translations are acceptable, but that an initial capital was more common and felt more natural. I also checked this with a native Slovak speaker who is also fluent in Czech, and they had the same opinion.
Greetings from Prague!