feat: add supautils.superuser GUC #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acts the same as the supautils.privileged_extensions_superuser GUC, this is still maintained for backwards compatibility. Also renames variables to clarify the codebase.
steve-chavez
commented
Dec 11, 2024
| static char *privileged_extensions_custom_scripts_path = NULL; | ||
| static char *privileged_role = NULL; | ||
| static char *privileged_role = NULL; // the privileged_role is a proxy role for the `supautils.superuser` role |
There was a problem hiding this comment.
@soedirgo This comment clarifies a lot, let me know if it's correct.
laurenceisla
approved these changes
Dec 11, 2024
|
Not fully acquainted with the code base but the change seems harmless. Approving to unblock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acts the same as the
supautils.privileged_extensions_superuserGUC, this is still maintained for backwards compatibility.Also renames variables to clarify the codebase.
Related to the discussion on #67 (comment)