feat: support non-superuser event trigger #98
+254
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-chavez
force-pushed
the
event-trigger
branch
from
751664a to
262251b
Compare
The `privileged_role` is able to switch to superuser to create event triggers. To prevent privesc, superusers and `reserved_roles` skip event trigger execution. Limitation: create extension will not fire event triggers, since extensions are created by superuser.
steve-chavez
force-pushed
the
event-trigger
branch
from
262251b to
5896474
Compare
|
The constrained extensions feat is failing bc of some change in CI resources, it doesn't fail locally. So its unrelated to this PR. Just commenting those tests for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67.
The
privileged_roleis able to switch to superuser to create event triggers.To prevent privesc, superusers and
reserved_rolesskip event trigger execution.Limitation: while doing
create extensionevent triggers will not be fired, since extensions are created by a superuser.Implementation
It uses the
fmgr_hookto skip event triggers. However note thatfmgr_hookdoesn't really offer a direct way to say "skip this function execution" (although we can abort withereport), so to achieve this the workaround is to override theFmgrInfoand turn into a noop.