feat: compatibility with pg 17 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pg 17, `makeJsonLexContextCstringLen` changed its signature. From: JsonLexContext * makeJsonLexContextCstringLen(const char *json, size_t len, int encoding, bool need_escapes) To: JsonLexContext * makeJsonLexContextCstringLen(JsonLexContext *lex, const char *json, size_t len, int encoding, bool need_escapes)
pashkinelfe
approved these changes
Oct 7, 2024
|
Need to test if this compiles on mac |
soedirgo
approved these changes
Oct 8, 2024
|
@soedirgo likely we can compensate in the nix package in supabase/postgres specifically for macos if we need to Although you may also need that support in this project as well I suppose. |
|
Yeah - not that we need macos support in our infra but I need it to actually work on it 😅 |
We now have CI for MacOS #93. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pg 17,
makeJsonLexContextCstringLenchanged its signature.From:
To: