Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: compile on pg16 #77

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

steve-chavez
Copy link
Member

@steve-chavez steve-chavez commented Jan 30, 2024

Only tests that we compile on pg16, it doesn't test the features on pg16 yet (see #61 (comment)). It depends on removing pg_cron from tests (see #76 (comment)).

Replace pg_cron which gives issues when compiling on pg 14 and 16.
@steve-chavez steve-chavez changed the title Compile pg16 chore: compile on pg16 Jan 30, 2024
@steve-chavez steve-chavez requested a review from soedirgo January 30, 2024 20:52
@soedirgo
Copy link
Member

sadness ensues

       > sed 's,EXTVERSION,1.0.4,g; s,EXTNAME,pg_tle,g; s,SCHEMA,pgtle,g' pg_tle.control.in > pg_tle.control;
       > installing
       > cp: missing destination file operand after '/nix/store/3nfq9nxb8m5zmv5wnwfgzshgdpyjhl8n-pg_tle-1.0.4/lib'
       > Try 'cp --help' for more information.

@steve-chavez
Copy link
Member Author

@soedirgo Hm, you mean pg_tle fails in pg 16? I can't seem to reproduce.

Anyway, if pg_tle is an issue maybe we can replace it by a contrib extension in the tests. Will work on that on another PR.

@steve-chavez steve-chavez merged commit 78f14ab into supabase:master Jan 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants