Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable sysinfo checks on macos #74

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

soedirgo
Copy link
Member

can't compile on macos otherwise

@soedirgo soedirgo changed the title fix: disable extension constraints on macos fix: disable linux-specific extension constraints on macos Jan 22, 2024
@soedirgo soedirgo changed the title fix: disable linux-specific extension constraints on macos fix: disable sysinfo checks on macos Jan 22, 2024
@soedirgo soedirgo force-pushed the fix/disable-extension-constraints-on-mac branch from e2dea6e to 6c2c7ef Compare January 22, 2024 09:45
Copy link
Member

@steve-chavez steve-chavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now. Should probably disable the feature altogether on MacOS.

@soedirgo soedirgo merged commit 6c9afe0 into master Jan 25, 2024
8 checks passed
@soedirgo soedirgo deleted the fix/disable-extension-constraints-on-mac branch January 25, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants