fix: prevent nested switch_to_superuser() from corrupting prev_role_*
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soedirgo
force-pushed
the
fix/nested-switch-to-superuser
branch
2 times, most recently
from
0683256 to
19374ca
Compare
soedirgo
force-pushed
the
fix/nested-switch-to-superuser
branch
3 times, most recently
from
a335308 to
f866285
Compare
soedirgo
force-pushed
the
fix/nested-switch-to-superuser
branch
from
f866285 to
94d6890
Compare
Comment on lines
+73
to
+79
| -- original role is restored on nested switch_to_superuser() | ||
| create extension autoinc; | ||
| select current_role; | ||
| current_role | ||
| ----------------- | ||
| extensions_role | ||
| (1 row) |
steve-chavez
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused an issue here: https://github.com/supabase/postgres/actions/runs/7551764226/job/20561373521#step:15:4305
TODO: