fix: not allowing to alter schema on non-extension

This bug was introduced by

- fcb20b3
- #94

src/supautils.c

@@ -425,24 +425,26 @@ static void supautils_hook(PROCESS_UTILITY_PARAMS) {
    * ALTER EXTENSION <extension> SET SCHEMA
    */
   case T_AlterObjectSchemaStmt: {
-      if (superuser()) {
-          break;
-      }
-      if (privileged_extensions == NULL) {
-          break;
-      }
-
       AlterObjectSchemaStmt *stmt = (AlterObjectSchemaStmt *)pstmt->utilityStmt;
 
       if (stmt->objectType == OBJECT_EXTENSION){
+          if (superuser()) {
+              break;
+          }
+          if (privileged_extensions == NULL) {
+              break;
+          }
+
           handle_alter_extension(prev_hook,
                                  PROCESS_UTILITY_ARGS,
                                  strVal(stmt->object),
                                  privileged_extensions,
                                  supautils_superuser);
+
+         return;
       }
 
-      return;
+      break;
   }
 
   /*

test/expected/privileged_extensions.out

@@ -132,3 +132,13 @@ and routine_schema = 'xtens';
  t
 (1 row)
 
+-- users can change tables schemas normally
+reset role;
+set role nonsuper;
+create table public.qux();
+create schema baz;
+alter table public.qux set schema baz;
+select * from baz.qux;
+--
+(0 rows)
+

test/fixtures.sql

@@ -24,3 +24,13 @@ grant all on database postgres to privileged_role;
 create role extensions_role login nosuperuser;
 grant all on database postgres to extensions_role;
 alter default privileges for role postgres in schema public grant all on tables to extensions_role;
+
+-- non-superuser that should be unaffected by extension logic when creating db objects
+create user nonsuper nosuperuser;
+grant all privileges on database contrib_regression to nonsuper;
+grant all on schema public to nonsuper;
+-- also allow on postgres db for quick manual tests
+\c postgres
+grant all on schema public to nonsuper;
+grant all privileges on database postgres to nonsuper;
+\c contrib_regression

test/sql/privileged_extensions.sql

@@ -89,3 +89,12 @@ select count(*) = 3 as extensions_in_xtens_schema
 from information_schema.routines
 where routine_name in ('page_header', 'heap_page_items', 'bt_metap')
 and routine_schema = 'xtens';
+
+-- users can change tables schemas normally
+reset role;
+set role nonsuper;
+
+create table public.qux();
+create schema baz;
+alter table public.qux set schema baz;
+select * from baz.qux;