fix: usage of net schema when the postgres role misses privileges #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-chavez
commented
Mar 14, 2024
Comment on lines
+74
to
+92
| def test_net_fails_when_postgres_unprivileged(sess): | ||
| """If the postgres role is unprivileged (no superuser + no privileges), the request will fail. This can happen on cloud databases where postgres is no superuser and the initial pg_net postgres privileges are revoked (can happen when upgrading).""" | ||
|
|
||
| with pytest.raises(Exception) as execinfo: | ||
| sess.execute(text(""" | ||
| set local role postgres; | ||
|
|
||
| -- assume postgres is no superuser and has lost explicit privileges | ||
| alter role postgres nosuperuser; | ||
| revoke all on all tables in schema net from postgres; | ||
|
|
||
| -- still, assume postgres has grant usage on the schema net | ||
| grant usage on schema net to postgres; | ||
|
|
||
| select net.http_get( | ||
| 'http://localhost:8080/anything' | ||
| ); | ||
| """)).fetchone() | ||
| assert "permission denied for table http_request_queue" in str(execinfo) |
There was a problem hiding this comment.
Here's a repro of https://github.com/orgs/supabase/discussions/21450
steve-chavez
changed the title
|
Is this ready for review? There's no code/SQL changes |
|
Follow up on #158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/orgs/supabase/discussions/21450.
Notes