Remove react modal #2858
Closed
Remove react modal #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update component sing native dialog and polyfill * create new ModalContext * add tests * add translations * add documentation * update NotificationModal component * export components * fix scroll-disabling styles * require min typescript version of 4.1 * fix ::backdrop inheritance issue for older browsers * add changeset * fix package-lock.json * fix animation duration * fix: classes order * Silence lint warnings in CI * Format Modal.mdx * fix CI * refactor styles * fix tests * code review Pt 1 * optimise scrolling * use useStack * export useScrollLock * refactor hasNativeDialogSupport * format file * cde review pt1 * add doc * refactor styles * improve closing modal on unmount * refactor tests * styles * fix useRef * fix scroll affordance * add layout padded * add doc to useScrollLock * fix params * restore scroll on clean up * fix CR workflow that creates previews based on main when using `issue_comment` * remove unused animation styles * add explanation for box-shadow workaround * use label workaround * change DateInput positioning to fixed * fix modal width * add post CR comment --------- Co-authored-by: Connor Bär <[email protected]>
🦋 Changeset detectedLatest commit: 43b003b The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +5.44 kB (+0.81%) Total Size: 677 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2858 +/- ##
==========================================
+ Coverage 87.75% 87.84% +0.08%
==========================================
Files 221 221
Lines 12746 12846 +100
Branches 1730 1771 +41
==========================================
+ Hits 11185 11284 +99
- Misses 1506 1509 +3
+ Partials 55 53 -2
|
|
replaced by #2903 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #ticket-number.
Purpose
Describe what you are trying to accomplish
Approach and changes
Describe how you solved the problem
Definition of done