Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rough logo desgins for leeteasy notifications #38

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Dishant10
Copy link

Added rough draft for logo design. Your suggestions are welcomed. I'm happy make any changes or even make a new one altogether. Added both with and without background png files.

Copy link
Owner

@sudiptob2 sudiptob2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, I think color needs to pop a little bit more. Also can you user the text Leet Easy instead of daily easy?

@Dishant10
Copy link
Author

Noted! I'll do the needful changes. Sure, I'll change the text.

@Dishant10
Copy link
Author

@sudiptob2 Added new designs, used green colour primarily because all the daily challenges are presented with a green icon. Because of black outer ring the inside icon and yellow Leetcode colour pops more. Changed the text to Leet Easy with greater font size for easier visibility even when used as a notification icon.
Any other suggestions are welcomed.
Thanks!

@sudiptob2
Copy link
Owner

Thanks a lot, I will think about your design 🙏

@sudiptob2 sudiptob2 marked this pull request as draft October 6, 2022 09:14
@Dishant10
Copy link
Author

I can work on it a bit more if you want too. Just suggest somethings you didn't like or things you want to add.

@Dishant10
Copy link
Author

Any updates regarding what have you decided about the designs? If possible could you please remove the draft tag or make this a normal PR and probably merge whenever you've finalised a design, cause it will count as a valid PR if the draft is removed. Otherwise it will be not counted and will be considered as spam.
Thank you!

@sudiptob2
Copy link
Owner

Otherwise it will be not counted and will be considered as spam. Thank you!

I don't think a draft PR is a spam PR. wer conventionally mark a PR draft until we are done with changes. I thought you are gonna update the disinge/working on the design that's why I marked it as a draft. You should be able to mark it as ready_for_review at anytime by clicking the button.
image

Regarding the current design, I am looking for a more matured design in this case. I appreciate your effort 💯

@Dishant10 Dishant10 marked this pull request as ready for review October 17, 2022 18:05
@Dishant10
Copy link
Author

Oh okay. I asked for your additional suggestions, I thought you don't want anything else from my design. Else I would have implemented the required changes like I did it previously. I'll also look forward to more design inspiration in the mean time.
Thank you!

@sudiptob2
Copy link
Owner

@Dishant10
I really don't have much experience in design so I am not able to give any fruitful suggestions. Please try to use your imagination and creativity 🙏

@sudiptob2 sudiptob2 marked this pull request as draft October 27, 2022 10:34
@sudiptob2 sudiptob2 marked this pull request as ready for review October 27, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants